Skip to content

chore(verification): remove intro screen when verifying both phone and email #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jul 9, 2026
Merged

chore(verification): remove intro screen when verifying both phone and email #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/AppRoute.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ sealed interface AppRoute : NavKey, Parcelable {
) : AppRoute, FlowRouteWithResult<VerificationResult> {
override val initialStack: List<NavKey>
get() = buildVerificationInitialStack(
origin = origin,
includePhone = includePhone,
includeEmail = includeEmail,
emailAddress = email,
Expand Down Expand Up @@ -271,15 +270,11 @@ sealed interface AppRoute : NavKey, Parcelable {
}

private fun buildVerificationInitialStack(
origin: AppRoute,
includePhone: Boolean,
includeEmail: Boolean,
emailAddress: String?,
emailVerificationCode: String?,
): List<NavKey> {
if (includePhone && includeEmail) {
return listOf(VerificationStep.Intro(origin is AppRoute.Token.Swap))
}
if (includePhone) {
return listOf(VerificationStep.PhoneEntry)
}
Expand Down
4 changes: 0 additions & 4 deletions apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/verification/VerificationStep.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import kotlinx.serialization.Serializable
*/
@Serializable
sealed interface VerificationStep : FlowStep, Parcelable {
@Parcelize
@Serializable
data class Intro(val isForOnRamp: Boolean) : VerificationStep

@Parcelize
@Serializable
data object PhoneEntry : VerificationStep
Expand Down
4 changes: 0 additions & 4 deletions ...ification/src/main/kotlin/com/flipcash/app/contact/verification/VerificationFlowScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import androidx.navigation3.runtime.NavKey
import androidx.navigation3.runtime.entryProvider
import com.flipcash.app.contact.verification.email.EmailMagicLinkContent
import com.flipcash.app.contact.verification.email.EmailVerificationContent
import com.flipcash.app.contact.verification.internal.VerificationFlowIntroContent
import com.flipcash.app.contact.verification.phone.PhoneCodeContent
import com.flipcash.app.contact.verification.phone.PhoneCountryCodeContent
import com.flipcash.app.contact.verification.phone.PhoneVerificationContent
Expand Down Expand Up @@ -59,9 +58,6 @@ fun VerificationFlowScreen(
private fun verificationEntryProvider(
route: AppRoute.Verification,
): (NavKey) -> NavEntry<NavKey> = entryProvider {
annotatedEntry<VerificationStep.Intro> { step ->
VerificationFlowIntroContent(isForOnRamp = step.isForOnRamp)
}
annotatedEntry<VerificationStep.PhoneEntry> {
PhoneVerificationContent()
}
Expand Down
149 changes: 0 additions & 149 deletions ...main/kotlin/com/flipcash/app/contact/verification/internal/VerificationFlowIntroScreen.kt
View file
Open in desktop

This file was deleted.

Loading