fix(phone): stop reporting expected phone-parse failures as notifiable Bugsnag warnings#1064
Merged
bmc08gt merged 1 commit intoJul 10, 2026
Conversation
…e Bugsnag warnings PhoneUtils.makeE164 reported NumberParseException via ErrorUtils.handleError when a user's entered number failed to parse for the selected region — an expected condition mid-onboarding phone verification, surfaced in production Bugsnag as a notifiable warning. Swallow NumberParseException/NumberFormatException silently and return "", matching the sibling toE164/parseInternationalNumber/isPhoneNumberValid methods. Genuinely unexpected exceptions are still routed through ErrorUtils.handleError. Adds PhoneUtilsTest coverage for cleanNumber: valid national/plus-prefixed numbers format to E164, expected parse failures are swallowed without reporting, and unexpected failures are still reported. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhoneUtils.makeE164 reported NumberParseException via ErrorUtils.handleError when a user's entered number failed to parse for the selected region — an expected condition mid-onboarding phone verification, surfaced in production Bugsnag as a notifiable warning.
Swallow NumberParseException/NumberFormatException silently and return "", matching the sibling toE164/parseInternationalNumber/isPhoneNumberValid methods. Genuinely unexpected exceptions are still routed through ErrorUtils.handleError.
Adds PhoneUtilsTest coverage for cleanNumber: valid national/plus-prefixed numbers format to E164, expected parse failures are swallowed without reporting, and unexpected failures are still reported.