fix(analytics): actually put amount properties in asProperties maps#1068
Merged
Conversation
Fiat.asProperties() and LocalFiat.asProperties() built pairs with bare `to` expressions inside buildMap without put(), so the resulting maps were empty and every transfer/onramp/wallet event was sent to Mixpanel without Fiat/Currency/USDC/Quarks (and Exchange Rate/Mint) properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fiat.asProperties()andLocalFiat.asProperties()inshared/analyticsbuilt their entries with bare"key" to valueexpressions insidebuildMap— creatingPairs and immediately discarding them instead of callingput(). Both helpers returned empty maps.As a result, every analytics event that attaches an amount has been reaching Mixpanel with no amount data at all:
transfer()events — Grab Bill, Give Bill, Withdrawal, Sent Cash, Send/Receive Cash Link — missingFiat/Currency/USDC/Quarks(andExchange Rate/Mintfor local fiat amounts)Invoke Payment,Completed)Wallet: Request Amount)Fix
Use
put()insidebuildMap. No call-site changes — properties flow through the existingtrack()plumbing.Testing
:apps:flipcash:shared:analyticscompiles and unit tests pass