Feat/charts#694
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/2560714172 Status: Passed Job summariesstorybook:buildStorybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/14595254281/artifacts/storybook-static/index.html |
| color?: string | ||
| } | ||
|
|
||
| function ChartTooltipContent({ |
There was a problem hiding this comment.
why defining a custom content in the first place. Just use the rechart component and give it some styling.
| nameKey?: string | ||
| } | ||
|
|
||
| function ChartLegendContent({ |
There was a problem hiding this comment.
why defining a custom content in the first place. Just use the rechart component and give it some styling.
|
|
||
| return ( | ||
| <ChartContainer config={resolvedConfig} {...containerProps}> | ||
| <RechartsPrimitive.LineChart data={data} {...chartProps}> |
There was a problem hiding this comment.
Why manually checking for props and rendering those. Simple override the component with custom styling
| legendProps?: React.ComponentProps<typeof RechartsPrimitive.Legend> | ||
| } | ||
|
|
||
| export function LineChart<TData extends Record<string, unknown>>({ |
There was a problem hiding this comment.
Follow standard and change to const React.FC function
| name?: string | ||
| } | ||
|
|
||
| export interface LineChartProps<TData extends Record<string, unknown>> |
There was a problem hiding this comment.
Extend from Pictor Component
2 participants
No description provided.