Fix @import order in tokens.css to stop invalid CSS after bundling - #10
Merged
Conversation
Consumers' bundlers (Vite/lightningcss) inline the local @fontsource @import rules as real CSS content in place, but leave the remote Google Fonts @import literal. With the Google Fonts import listed after the @fontsource ones, it ended up after real rules post-bundle, which is invalid per spec ("@import rules must precede all rules") and surfaced as a build warning in every consuming app. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@importinsrc/tokens.csswas listed after the local@fontsource/jetbrains-mono@imports@importended up after real rules, which is invalid per spec ("@import rules must precede all rules")@importabove the@fontsourceimports so it stays first regardless of what the bundler inlinesTest plan
npm run buildin this repo succeeds,dist/tokens.cssreflects the new ordernpm run build): the "@import rules must precede all rules" warning is gone🤖 Generated with Claude Code