Widen apexcharts peer range to include v6 - #9
Merged
Conversation
apexcharts 6.6.1 is a straight major bump for this Chart wrapper — it only ever touches the stable new ApexCharts()/.render()/.updateOptions()/ .destroy() surface, no removed/renamed APIs. Verified via full build, storybook build, lint, typecheck, and the Playwright smoke suite (including the Chart story) against apexcharts@6.6.1. Unblocks consuming apps (e.g. flows-portal.docuhub) picking up dependabot's apexcharts 5→6 bump without violating this package's peer range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apexchartspeer dependency range from^4.5.0 || ^5.0.0to^4.5.0 || ^5.0.0 || ^6.0.0apexchartsdevDependency used for local dev/Storybook/Playwright to^6.6.1Why
Consuming apps (e.g. flows-portal.docuhub) have a dependabot PR bumping
apexcharts5→6, but it's blocked by this package's peer range.Chart.vueonly calls the stablenew ApexCharts()/.render()/.updateOptions()/.destroy()surface, which is unchanged across the major bump.Test plan
npm install(runsbuildincl.verify:externals) — passesnpm run lint— passes (5 pre-existing warnings, unrelated)npm run typecheck— passesnpm run build-storybook— passesnpm run test:ci(Playwright, incl.Organisms/Chart — Area Runs) — 198/198 passed