Skip to content

Add default setup notifications#93

Merged
codeforester merged 1 commit into
masterfrom
hpr/setup-notifications
May 27, 2026
Merged

Add default setup notifications#93
codeforester merged 1 commit into
masterfrom
hpr/setup-notifications

Conversation

@codeforester
Copy link
Copy Markdown
Owner

@codeforester codeforester commented May 27, 2026

Summary

  • make basectl setup send best-effort macOS completion/failure notifications by default
  • skip notifications during --dry-run
  • add basectl setup --no-notify and BASE_SETUP_NOTIFY=false as opt-outs
  • resolve named setup projects through workspace discovery before invoking base_setup
  • pass an explicit manifest to base_setup so basectl setup <project> does not accidentally use the current directory's nearest manifest
  • return Python setup-layer failures without dumping a Bash fatal stack trace
  • document the notification behavior and remove the completed TODO item
  • add BATS coverage for default success, default failure, dry-run skip, CLI opt-out, env opt-out, help text, and named project manifest resolution

Validation

  • bash -n cli/bash/commands/basectl/subcommands/setup.sh
  • bash -n cli/bash/commands/basectl/subcommands/setup_common.sh
  • bats cli/bash/commands/basectl/tests/setup.bats
  • bats cli/bash/commands/basectl/tests/basectl.bats
  • env BASE_CACHE_DIR=/private/tmp/base-cache-test /Users/rameshhp/work/base/bin/basectl setup --dry-run --no-notify brew
  • git diff --check

@codeforester codeforester force-pushed the hpr/setup-notifications branch from d4817e1 to 75baed0 Compare May 27, 2026 08:40
@codeforester codeforester changed the title Add optional setup notifications Add default setup notifications May 27, 2026
@codeforester codeforester merged commit 837726f into master May 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant