fix: resolve TypeError in CLIRequest::parseCommand when argv is missing#10415
Open
gr8man wants to merge 1 commit into
Open
fix: resolve TypeError in CLIRequest::parseCommand when argv is missing#10415gr8man wants to merge 1 commit into
gr8man wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In environments where
$_SERVER['argv']is not populated or explicitly set tonull(e.g., during testing or non-standard executions), instantiatingCLIRequestthrows aTypeError: array_shift(): Argument #1 ($array) must be of type array, null givenon modern PHP versions.This PR resolves the issue by defaulting
$argsto an empty array before callingarray_shift(). A corresponding unit testtestParseCommandWithMissingArgvhas been added toCLIRequestTestto ensure the class initializes properly under these conditions without throwing an error.Checklist: