fix: skip unreadable .env in Boot::loadDotEnv for separate-process tests#10417
Open
gr8man wants to merge 3 commits into
Open
fix: skip unreadable .env in Boot::loadDotEnv for separate-process tests#10417gr8man wants to merge 3 commits into
gr8man wants to merge 3 commits into
Conversation
The loadDotEnv() method now checks if the .env file exists and is readable before attempting to load it. This prevents a fatal error when tests run in separate processes (e.g. with @RunInSeparateProcess) where the .env file may not be accessible. Fixes testHeaderOverride error in ResponseSendTest.
michalsn
requested changes
Jul 20, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Now we would silently ignore a present but unreadable .env file. Not acceptable.
If you identified the test that causes this, you may configure the test bootstrap to use a controlled environment directory.
…ng unreadable .env Per review feedback, instead of silently skipping an unreadable .env in Boot::loadDotEnv(), configure the test bootstrap to use a controlled environment directory. This ensures separate-process tests don't fail when .env becomes unreadable due to test pollution. - Revert is_file/is_readable guard in Boot::loadDotEnv() (retain production error handling for unreadable .env) - Replace null coalescing with property_exists() for envDirectory - Set $paths->envDirectory = $paths->testsDirectory in test bootstrap
gr8man
force-pushed
the
fix/load-dotenv-unreadable-silent
branch
from
July 20, 2026 17:56
352e956 to
92eac67
Compare
michalsn
reviewed
Jul 21, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Please identify the test or operation that changes the file's permissions and causes the error.
I cannot recreate the issue by running the test command you provided.
| // Use a controlled environment directory for tests so that | ||
| // separate-process tests don't fail on an unreadable .env file. | ||
| $paths->envDirectory = $paths->testsDirectory; | ||
|
|
Member
There was a problem hiding this comment.
This changes behavior for every application test suite. Again, not acceptable.
Comment on lines
-208
to
+210
| $envDirectory = $paths->envDirectory ?? $paths->appDirectory . '/../'; // @phpstan-ignore nullCoalesce.property | ||
| (new DotEnv($envDirectory))->load(); | ||
|
|
||
| $envDir = $paths->envDirectory ?? dirname($paths->appDirectory); // @phpstan-ignore nullCoalesce.property | ||
| (new DotEnv($envDir))->load(); |
Member
There was a problem hiding this comment.
This is an unrelated change. If you want, you can send a separate PR with the refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
ResponseSendTest::testHeaderOverridefails when tests run in random order because the spawned process (#[RunInSeparateProcess]) callsBoot::loadDotEnv()→DotEnv::parse(), which throwsInvalidArgumentExceptionwhen.envexists but is unreadable. The fix adds an earlyis_file()+is_readable()guard soloadDotEnv()returns silently —.envis optional.Tests
No new tests —
DotEnvTest::testLoadsUnreadableFilealready covers the exception path. Verified with: