test: migrate Docker orchestration to testcontainers-go#374
test: migrate Docker orchestration to testcontainers-go#374ethanndickson wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
71f5067 to
0a754e2
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a754e2e19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0a754e2 to
1503379
Compare
|
@codex review re: Bind the Coder test port to loopback Thanks — I dug into this. You're right that the old hand-rolled Docker setup explicitly bound the published Coder port to I don't think we should take the loopback binding change as part of this migration, though. The idiomatic testcontainers API here is The practical risk seems acceptable for this test harness: the instance is ephemeral, uses a random host port, is short-lived, and runs inside the test runner environment. If we want localhost-only published ports as a hard security requirement, I think that should be a separate hardening change with explicit handling for testcontainers host resolution across Docker environments. I did keep the other fix from this review: cleanup and failure log collection are now registered immediately after |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1503379828
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1503379 to
734112b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |

Replaces the hand-rolled Docker SDK container lifecycle in
integration/integration.gowithtestcontainers-go.StartCoder's signature and all its options are unchanged, so the acceptance and integration test callsites are untouched.testcontainers handles image pulls, the mapped host port, readiness waiting, and cleanup, which lets us delete the
pullImageandrandomPorthelpers and dropdocker/dockeras a direct dependency.Closes PLAT-367.