Update check for Python & squash bug related to gallery/ directory#1
Open
dtf0 wants to merge 4 commits into
Open
Update check for Python & squash bug related to gallery/ directory#1dtf0 wants to merge 4 commits into
gallery/ directory#1dtf0 wants to merge 4 commits into
Conversation
`command -v` is preferred over `type` for this purpose and is POSIX-specified for the exit-status check. Reason for fix: I don't have `python` installed on my path, but it is aliased to `python3`. Script was failing to load webserver after building.
Took a little digging (tried updating the file path on `console.log("Fetching json file: " + file);` in `CCUtil.js` first), but found where it actually gets called at the top-level config.
Reason for fix: failed to fetch `gallery-index.json` and images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update check for Python
File:
run_server.shcommand -vis preferred overtypefor this purpose and is POSIX-specified for the exit-status check.Reason for fix: I don't have
pythoninstalled on my path, but it is aliased topython3. Script was failing to load webserver after building.Squash bug related to
gallery/directoryFile:
package.jsonTook a little digging (tried updating the file path on
console.log("Fetching json file: " + file);inCCUtil.jsfirst), but found where it actually gets called at the top-level config.Reason for fix: failed to fetch
gallery-index.jsonand images.Suggested edit: change
showGithubLink = falsetotrue. Broadcast your work on the clones of thieves!(in fairness, toggling this is what helped me find the directory bug and squash it, so ¯\(ツ)/¯ )
Thanks for making this publicly available.