Fix zmq and ROSS compilation issues#240
Open
sanjaychari wants to merge 9 commits into
Open
Conversation
The kronos-develop-director-b branch of CODES was using an outdated version of ROSS and also had compilation issues because of zeromq. This commit changes it to be compatible with the master branch of ROSS and fixes the zeromq compilation issues.
sanjaychari
changed the title
Compilation with torch-jit was not occuring even with torch_enable set to 1. This commit fixes torch-jit compilation with GPU support.
Author
sanjaychari
changed the title
Author
|
I ran a sequential simulation with a dummy PyTorch checkpoint file and this code works for sequential simulation. Conservative and optimistic simulation have some issues with GVT consistency but that might be solved by an accurate ML model, or in a separate pull request. |
Author
|
The GVT consistency issues with optimistic mode were happening because of network_treatment_on_switch being set to "freeze" in the CODES conf file. Events from the ML model were scheduled to arrive before GVT and were sent without any delay when received by the PDES simulation after the switch, and ROSS reported these as stragglers. Changing network_treatment_on_switch to "nothing" fixes the issue. |
Member
|
i'm good with merging this |
This commit makes the kronos-develop-director-b branch compatible with the master branch and introduces ML modelling code to be used with the director.
sanjaychari
force-pushed
the
kronos-develop-director-b
branch
from
63693c0 to
51f691b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kronos-develop-director-b branch of CODES was using an outdated version of ROSS and also had compilation issues because of zeromq and CUDA. This PR changes it to be compatible with the master branch of ROSS and fixes the zeromq and CUDA compilation issues.