Fix #51 -- Add argument to customize or disable Sentry monitors#55
Merged
Conversation
ddace85 to
72295b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 6 6
Lines 174 174
=======================================
Hits 172 172
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new sentry_monitor_config argument to the cron() decorator to allow per-task customization of Sentry Cron Monitor configuration or disabling Sentry monitoring entirely, with accompanying documentation and tests.
Changes:
- Extend
cron()to acceptsentry_monitor_configand forward it into the Sentry integration. - Update Sentry integration helper to accept an override config (or disable monitoring).
- Add tests and README docs covering disable/custom config behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
crontask/__init__.py |
Adds the new sentry_monitor_config keyword argument to cron() and wires it into Sentry monitoring. |
crontask/contrib/sentry.py |
Extends monitor wrapping logic to accept an explicit monitor config override (and should support disabling). |
tests/test_tasks.py |
Adds coverage for passing sentry_monitor_config through the cron() decorator. |
tests/contrib/test_sentry.py |
Adds unit tests for disabling monitoring and supplying a custom monitor config. |
README.md |
Documents how to disable Sentry monitoring per task via sentry_monitor_config=False. |
72295b9 to
3692756
Compare
3692756 to
34310c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.