Skip to content

feat(codegen): repoint introspection sources off services_public to constructive_routing_public - #1442

Merged
pyramation merged 1 commit into
mainfrom
feat/services-public-hard-break-codegen
Jul 25, 2026
Merged

feat(codegen): repoint introspection sources off services_public to constructive_routing_public#1442
pyramation merged 1 commit into
mainfrom
feat/services-public-hard-break-codegen

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Hard break: the codegen introspection sources no longer read services_public. API-name → schema-name resolution now queries the scoped routing schema. No fallback.

 SELECT DISTINCT ms.schema_name
-FROM services_public.api_schemas as_tbl
-JOIN services_public.apis api ON api.id = as_tbl.api_id
+FROM constructive_routing_public.api_schemas as_tbl
+JOIN constructive_routing_public.apis api ON api.id = as_tbl.api_id
 JOIN metaschema_public.schema ms ON ms.id = as_tbl.schema_id
 WHERE api.name = ANY($1)

The existence checks in validateServicesSchemas (renamed validateRoutingSchemas, with ServicesSchemaValidationRoutingSchemaValidation; both only used inside graphql/codegen) now check constructive_routing_public.apis / .api_schemas, and error strings say "routing schema deployed". database.ts, pgpm-module.ts, and types/config.ts only referenced services_public in doc comments — updated to match.

Shapes are identical between the two schemas (apis.name, api_schemas.api_id, api_schemas.schema_idmetaschema_public.schema.id), per __fixtures__/seed/scoped/test-data.sql, so the join needed no restructuring.

cd graphql/codegen && pnpm test: 20 suites / 358 tests pass. grep -rn services_public graphql/codegen → no matches.

Link to Devin session: https://app.devin.ai/sessions/4ce4dca1862f4736aeb646da1e9e22ec
Requested by: @pyramation

@pyramation pyramation self-assigned this Jul 25, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pyramation
pyramation merged commit 2b4ad8d into main Jul 25, 2026
15 checks passed
@pyramation
pyramation deleted the feat/services-public-hard-break-codegen branch July 25, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant