feat(codegen): repoint introspection sources off services_public to constructive_routing_public - #1442
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard break: the codegen introspection sources no longer read
services_public. API-name → schema-name resolution now queries the scoped routing schema. No fallback.The existence checks in
validateServicesSchemas(renamedvalidateRoutingSchemas, withServicesSchemaValidation→RoutingSchemaValidation; both only used insidegraphql/codegen) now checkconstructive_routing_public.apis/.api_schemas, and error strings say "routing schema deployed".database.ts,pgpm-module.ts, andtypes/config.tsonly referencedservices_publicin doc comments — updated to match.Shapes are identical between the two schemas (
apis.name,api_schemas.api_id,api_schemas.schema_id→metaschema_public.schema.id), per__fixtures__/seed/scoped/test-data.sql, so the join needed no restructuring.cd graphql/codegen && pnpm test: 20 suites / 358 tests pass.grep -rn services_public graphql/codegen→ no matches.Link to Devin session: https://app.devin.ai/sessions/4ce4dca1862f4736aeb646da1e9e22ec
Requested by: @pyramation