feat(codegen): cli.stashName so generated CLIs can share one signed-in state - #1651
Closed
pyramation wants to merge 1 commit into
Closed
feat(codegen): cli.stashName so generated CLIs can share one signed-in state#1651pyramation wants to merge 1 commit into
pyramation wants to merge 1 commit into
Conversation
…n state Also bumps genomic to ^5.6.4 so the workspace resolves a single inquirerer (4.9.3).
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codegen half of the one-store consolidation (constructive-planning#1430). A generated CLI passes its own name as the appstash tool name, so each one gets its own
~/.<cli>/and its own login. New optionalcli.stashNameseparates where state lives from what the tool is called:toolNamestill drives theCSDK_TOKEN/CSDK_API_ENDPOINTenv prefixes and the command names in error messages, so sharing a directory doesn't blur the tools' identities. Omitted → byte-identical output to today, so no regeneration is forced on existing consumers.Threaded through
generateExecutorFile,generateMultiTargetExecutorFileandgenerateHelpersFileas a trailing optional arg (AST, per the codegen rules —createStoreCall()builds the object expression only when a stash name is present).Also:
genomic^5.6.2 → ^5.6.4. The old genomic pinnedinquirerer@4.9.1transitively, so after #1650 the workspace resolved two copies andpgpm/corefailed to build on a private-property mismatch between them (Types have separate declarations of a private property 'rl'). One copy now.Nothing consumes
stashNameyet — csdk switching over (and deleting its localconfig-store.tsduplicate in favor of appstash's) needsstashNamein a published appstash, which is dev-utils#105; that lands as a follow-up PR.Tests: 3 cases in
cli-generator.test.ts(absent → plain call, single-target, multi-target executor + helpers). Full codegen suite 364 passing, 123 snapshots unchanged.Link to Devin session: https://app.devin.ai/sessions/783ae9ff63b445879450d5051d9d3d83
Requested by: @pyramation