DO NOT MERGE: Test build against c2pa-rs 0.90.0-rc.1#244
Open
scouten-adobe wants to merge 1 commit into
Open
Conversation
Point CI at the c2pa-rs 0.90.0-rc.1 release candidate (pinned to commit 66d20c655769b9a46fa87221a996ad5686e0c6f9, the HEAD of that branch) to surface any breaking build issues before the RC ships as a release. No prebuilt release binaries exist for the RC yet, so the default prebuilt-download path (C2PA_VERSION in CMakeLists.txt) cannot target it. Instead, CI checks out c2pa-rs at the pinned commit, installs Rust, and builds the c2pa_c FFI from source via C2PA_BUILD_FROM_SOURCE / C2PA_RS_PATH across the full OS matrix. MSVC setup is broadened to all Windows runners (with arch selected per runner) since building Rust from source needs it. This is intentionally temporary and self-contained in the workflow; revert the env block and the two "(TEMPORARY)" steps once the RC is released and C2PA_VERSION can be bumped normally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
scouten-adobe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (temporary / do not merge)
Exercise the c2pa-rs
0.90.0-rc.1release candidate against this repo's build and test suite before it ships as a real release, so any breaking build/API/FFI issues surface early.Pinned to commit
66d20c655769b9a46fa87221a996ad5686e0c6f9(the HEAD of branch0.90.0-rc.1) for reproducibility.Why this is a CI-only change
The default build downloads prebuilt release binaries selected by
C2PA_VERSIONinCMakeLists.txt. There is noc2pa-v0.90.0-rc.1release (latest isc2pa-v0.89.3), so there are no prebuilt binaries to point at.The only way to exercise the RC is the existing build-from-source path. So this PR changes
.github/workflows/ci.ymlto:contentauth/c2pa-rsat the pinned commit intoc2pa-rs/.c2pa_cFFI from source viaC2PA_BUILD_FROM_SOURCE=1+C2PA_RS_PATH, instead of downloading theC2PA_VERSIONprebuilt.Runs across the full OS matrix (Windows x64/arm64, macOS arm64/intel, Ubuntu x64/arm64). Note: source builds are officially "only tested on Linux," so non-Linux failures may reflect source-build toolchain integration rather than genuine RC breakage — read results with that in mind.
CMakeLists.txtis intentionally left untouched so the change is fully contained in the workflow and trivial to revert.Reverting
Once the RC ships as a release, revert the
env:block and the two(TEMPORARY)steps in.github/workflows/ci.yml, then bumpC2PA_VERSIONinCMakeLists.txtnormally.🤖 Generated with Claude Code