Typescript migration and fixes#22
Open
jacobsjo wants to merge 5 commits into
Open
Conversation
Convert all bundle sources from JavaScript to TypeScript with strong typing. Add a local api.ts for domain types and an index.d.ts for the vendored dn_charting-c3 library, derive typed i18n Messages, and apply license headers.
Separate the reactive Mutable state model from a behavior controller, mark private fields and methods, type selection events, convert to async/await, and replace ct_lang helpers with plain JS.
Fix the related-data fetch (use apprtFetchJson and quote string join keys) and demonstrate it in the sample app with a Kreisgrenzen relationship.
pswienty
approved these changes
Jun 17, 2026
ct-mgadomski
approved these changes
Jun 18, 2026
| /// limitations under the License. | ||
| /// | ||
|
|
||
| import d_string from "dojo/string"; |
There was a problem hiding this comment.
Ggf. könnte man die dojo-Abhängigkeit noch durch plain TS ersetzen?
|
|
||
| export default class C3ChartsFactory { | ||
|
|
||
| declare private c3ChartsDataProvider: C3ChartsDataProvider; |
There was a problem hiding this comment.
Ich verstehe immer noch nicht wofür man "declare" benötigt. Weißt du das?
| readonly tooltip: string; | ||
| readonly priority?: number; | ||
|
|
||
| declare private controller: InjectedReference<ChartingDashboardController>; |
| import Vue from "apprt-vue/Vue"; | ||
| import VueDijit from "apprt-vue/VueDijit"; | ||
| import Binding, { type Bindable } from "apprt-binding/Binding"; | ||
| import d_aspect from "dojo/aspect"; |
There was a problem hiding this comment.
Dojo-Abhängigkeit. Kann man die ersetzen?
| import { declare } from "apprt-core/Mutable"; | ||
| import type { ChartsTab, Relationship, StoreChartsProperties, Tab } from "./api"; | ||
|
|
||
| export default declare({ |
| import type { ChartStore, FeatureAttributes, RelatedDataEntry, Relationship } from "./api"; | ||
|
|
||
| /** A feature returned by an esri feature service query. */ | ||
| interface EsriFeature { |
There was a problem hiding this comment.
Hierfür gibts doch locker types von der esri API oder? :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript migration + modernization
api.tsfor the bundle's domain types.to
async/await, and replacect/_langhelpers with plain JS.ChartingDashboardControllerfromChartingDashboardWidgetModel.QueryControllermethods (getMetadata,getRelatedMetadata,findRelatedRecords).Result-ui bulk action
ResultCenterChartingToolwith aresult-api.BulkTableActionPer-year charting via related tables (bug fix)
QueryController.getRelatedData: it usedapprtFetch(which returns aResponse) with a non-existenthandleAsoption, so the response body was neverparsed; switched to
apprtFetchJson.whereclause (AGS LIKE '05315') - unquoted string keys returned HTTP 400.Kreisgrenzen_2022layer joined to the income layer byAGSwithtimeAttribute: YEAR, rendering a per-year line chart.