feat: support the querystring parameter location and query operation - #14
Open
AdamFiser wants to merge 1 commit into
Open
feat: support the querystring parameter location and query operation#14AdamFiser wants to merge 1 commit into
AdamFiser wants to merge 1 commit into
Conversation
OpenAPI 3.2.0 added two constructs this library actively mishandled. A parameter with in: querystring, which treats the whole query string as one value, threw InvalidArgumentException because the location was not in the allowed list. Such a parameter must describe itself with content, which the previous commit made possible. A path item with a query operation lost it silently: setOperation() returns early for methods outside its allow list, so the operation vanished from toArray() without a word. Both are now known: Parameter::IN_QUERYSTRING and PathItem::OPERATION_QUERY.
AdamFiser
force-pushed
the
feat/openapi-3.2-query
branch
from
August 3, 2026 04:13
fb81d28 to
0c0e344
Compare
Contributor
Author
|
Rebased onto current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAPI 3.2.0 added two constructs this library actively mishandles:
in: querystringtreats the whole query string as a single value. It was rejected because the location was not inParameter::INS.queryoperation was dropped:setOperation()returns early for methods outside its allow list.Adds
Parameter::IN_QUERYSTRINGandPathItem::OPERATION_QUERY. Documents that do not use them are unaffected.A
querystringparameter describes itself withcontentrather thanschema, which #13 made possible.Tests:
ParameterTest::testQuerystringLocationand a newPathItemTest; the existingtestInvalidInmessage now lists the new location.