Skip to content

fix: FP when importing data (time keyword) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azurit wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: FP when importing data (time keyword) #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e16840
Update phpmyadmin-rule-exclusions-before.conf
azurit Jun 10, 2026
6b578d1
Comment out test case for data import in YAML
azurit Jun 10, 2026
b376817
Add test for FP related to data import command
azurit Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/phpmyadmin-rule-exclusions-before.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,9 @@ SecRule REQUEST_FILENAME "@endsWith /import.php" \
ctl:ruleRemoveTargetById=932140;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932150;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932160;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932230;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932235;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932250;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932370;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932380;ARGS:sql_query,\
ctl:ruleRemoveTargetById=933100;ARGS:sql_query,\
Expand Down Expand Up @@ -839,7 +841,9 @@ SecRule ARGS:route "@streq /import" \
ctl:ruleRemoveTargetById=932150;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932140;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932160;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932230;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932235;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932250;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932370;ARGS:sql_query,\
ctl:ruleRemoveTargetById=932380;ARGS:sql_query,\
ctl:ruleRemoveTargetById=933100;ARGS:sql_query,\
Expand Down
20 changes: 20 additions & 0 deletions tests/regression/phpmyadmin-plugin/9513290.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,23 @@
# output:
# log:
# no_expect_ids: [932180]
# - test_id: 3
# desc: FP related to data import (command time)
# stages:
# - input:
# dest_addr: 127.0.0.1
# headers:
# Host: localhost
# User-Agent: "OWASP CRS test agent"
# Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
# Cookie: phpMyAdmin=1
# port: 80
# method: POST
# version: HTTP/1.1
# uri: /post/import.php
# data: sql_query=CREATE%20TABLE%20t_event%20%28%0A%20%20id%20%20%20%20%20%20%20%20%20%20%20%20INT%20NOT%20NULL%20AUTO_INCREMENT%20PRIMARY%20KEY%2C%0A%20%20nl_castle_id%20%20INT%20NOT%20NULL%2C%0A%20%20nl_target_id%20%20INT%20NOT%20NULL%20DEFAULT%200%2C%0A%20%20uv_type%20%20%20%20%20%20%20VARCHAR%2832%29%20NOT%20NULL%2C%0A%20%20nl_amount%20%20%20%20%20INT%20NOT%20NULL%20DEFAULT%200%2C%0A%20%20uv_data%20%20%20%20%20%20%20TEXT%20NULL%2C%0A%20%20uv_result%20%20%20%20%20TEXT%20NULL%2C%0A%20%20ts_start%20%20%20%20%20%20TIMESTAMP%20NOT%20NULL%20DEFAULT%20current_timestamp%28%29%2C%0A%20%20ts_finish%20%20%20%20%20DATETIME%20NOT%20NULL%2C%0A%20%20nl_status%20%20%20%20%20VARCHAR%2816%29%20NOT%20NULL%20DEFAULT%20%27pending%27%2C%0A%20%20KEY%20ix_due%20%28nl_status%2C%20ts_finish%29%2C%0A%20%20KEY%20ix_castle%20%28nl_castle_id%29%0A%29%20ENGINE%3DInnoDB%20DEFAULT%20CHARSET%3Dutf8%20COLLATE%3Dutf8_slovak_ci%3B
# output:
# log:
# no_expect_ids:
# - 932230
# - 932250
20 changes: 20 additions & 0 deletions tests/regression/phpmyadmin-plugin/9513700.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,23 @@ tests:
output:
log:
no_expect_ids: [932180]
- test_id: 3
desc: FP related to data import (command time)
stages:
- input:
dest_addr: 127.0.0.1
headers:
Host: localhost
User-Agent: "OWASP CRS test agent"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Cookie: phpMyAdmin=1
port: 80
method: POST
version: HTTP/1.1
uri: /post/index.php?route=/import
data: sql_query=CREATE%20TABLE%20t_event%20%28%0A%20%20id%20%20%20%20%20%20%20%20%20%20%20%20INT%20NOT%20NULL%20AUTO_INCREMENT%20PRIMARY%20KEY%2C%0A%20%20nl_castle_id%20%20INT%20NOT%20NULL%2C%0A%20%20nl_target_id%20%20INT%20NOT%20NULL%20DEFAULT%200%2C%0A%20%20uv_type%20%20%20%20%20%20%20VARCHAR%2832%29%20NOT%20NULL%2C%0A%20%20nl_amount%20%20%20%20%20INT%20NOT%20NULL%20DEFAULT%200%2C%0A%20%20uv_data%20%20%20%20%20%20%20TEXT%20NULL%2C%0A%20%20uv_result%20%20%20%20%20TEXT%20NULL%2C%0A%20%20ts_start%20%20%20%20%20%20TIMESTAMP%20NOT%20NULL%20DEFAULT%20current_timestamp%28%29%2C%0A%20%20ts_finish%20%20%20%20%20DATETIME%20NOT%20NULL%2C%0A%20%20nl_status%20%20%20%20%20VARCHAR%2816%29%20NOT%20NULL%20DEFAULT%20%27pending%27%2C%0A%20%20KEY%20ix_due%20%28nl_status%2C%20ts_finish%29%2C%0A%20%20KEY%20ix_castle%20%28nl_castle_id%29%0A%29%20ENGINE%3DInnoDB%20DEFAULT%20CHARSET%3Dutf8%20COLLATE%3Dutf8_slovak_ci%3B
output:
log:
no_expect_ids:
- 932230
- 932250