configure: don't require corosync libs when --disable-qdevices is used#41
Open
skirmess wants to merge 1 commit into
Open
configure: don't require corosync libs when --disable-qdevices is used#41skirmess wants to merge 1 commit into
skirmess wants to merge 1 commit into
Conversation
libcorosync_common, libcmap and libvotequorum are only needed by corosync-qdevice, not by corosync-qnetd. Move the PKG_CHECK_MODULES calls for these libraries inside the enable_qdevices conditional so that systems without corosync installed can still build corosync-qnetd with --disable-qdevices. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/corosync-qdevice/job/corosync-qdevice-pipeline/job/PR-41/1/input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
libcorosync_common,libcmapandlibvotequorumare only needed bycorosync-qdevice, not bycorosync-qnetd. However,configurealwayschecked for these libraries unconditionally, even when
--disable-qdeviceswas passed. This made it impossible to build
corosync-qnetdon systemswithout corosync installed (e.g. a dedicated qnetd host running a non-Linux OS).
Fix
Move the three
PKG_CHECK_MODULEScalls for the corosync libraries insidethe
enable_qdevicesconditional, which is already used to guard theAM_CONDITIONAL(BUILD_QDEVICES, ...)call.Testing
Tested on Fedora with
--disable-qdevices(builds successfully withoutcorosync headers) and without the flag (configure correctly errors out when
corosync libraries are missing).
🤖 Generated with Claude Code