fix(updater): show friendly message when platform assets not yet uploaded#42
Merged
Merged
Conversation
…aded When a release is published (latest.json exists) but platform-specific binaries are still building, check() succeeds but downloadAndInstall() fails with 'None of the fallback platforms... were found in the response'. Catch this transient error in both checkForUpdate() and downloadAndInstall() and show a user-friendly message instead of the raw error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When release builds are still in progress and the user clicks Check for updates, Tauri's updater reports the new version as available (because
latest.jsonis published as soon as the first platform completes), but when the user clicks Download & Install, the call fails with the raw error:Root cause
There is a ~5–15 minute window during the release build where
latest.jsonexists on GitHub Releases but not all platform-specific binaries have been uploaded yet.check()returnsavailable: truebased on the version inlatest.json, butdownloadAndInstall()cannot find the requested platform's asset.Fix
Catch the
fallback platforms ... were found in the responseerror in bothcheckForUpdate()anddownloadAndInstall()and surface a friendly message instead:Verification
npm run check— 0 errors, 0 warnings