Skip to content

CHG: MHit cleanup #174

Merged
zoglauer merged 3 commits into
cositools:develop/emfrom
zoglauer:feature/MHit-cleanup
Jul 1, 2026
Merged

CHG: MHit cleanup #174
zoglauer merged 3 commits into
cositools:develop/emfrom
zoglauer:feature/MHit-cleanup

Conversation

@zoglauer

@zoglauer zoglauer commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

I performed the same cleanup for MHit.

Review-marked questions to be resolved in review meeting

@zoglauer zoglauer requested review from ckierans and fhagemann June 29, 2026 21:38
@zoglauer zoglauer added the cleanup Code cleanup label Jun 29, 2026
fhagemann
fhagemann approved these changes Jun 29, 2026
View reviewed changes
Comment thread src/MHit.cxx
@zoglauer zoglauer marked this pull request as ready for review July 1, 2026 19:07
@zoglauer

zoglauer commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

All changes in.

@zoglauer zoglauer requested a review from fhagemann July 1, 2026 19:07
@fhagemann

fhagemann commented Jul 1, 2026

Copy link
Copy Markdown

Looks good to me.
I would have some questions about Origins in the DEE, but that would be unrelated to this PR:
(Basically: we currently generate three strip hits per hit in the detector, namely main strip the two nearest neighbors --> should they then all carry the same Origins information? just the main strip?)

@zoglauer zoglauer merged commit 1a1b3ee into cositools:develop/em Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhagemann fhagemann fhagemann approved these changes
@ckierans ckierans Awaiting requested review from ckierans

Assignees

No one assigned

Labels

cleanup Code cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoglauer @fhagemann