Skip to content

Remove Opera sniff#4

Open
miketaylr wants to merge 1 commit into
cowboy:masterfrom
miketaylr:master
Open

Remove Opera sniff#4
miketaylr wants to merge 1 commit into
cowboy:masterfrom
miketaylr:master

Conversation

@miketaylr

Copy link
Copy Markdown

SUP BEN.

Opera 9.64 is like, 9 versions old. I know Ryan has a fork that normalizes its old document.postMessage implementation--but I think that's going to help like 0.01% of all Opera users. So....this is easier and won't break any sites or provide a crappy fallback for current Opera users.

@miketaylr

Copy link
Copy Markdown
Author

Ben, want me to um write a test for this or something?

@miketaylr

Copy link
Copy Markdown
Author

Beatport.com users can't complete the checkout process because of this sniff now too. 😞

@alexmchardy

Copy link
Copy Markdown

We're patched now at Beatport. Thanks for the fix!

@jtsoi

jtsoi commented Mar 21, 2012

Copy link
Copy Markdown

I was about to make the same pull request, Opera now supports postMesage.

Ben, are you alive? =)

/JT

@chrisdavidmills

Copy link
Copy Markdown

+1 on this from me too!

@alloy-d

alloy-d commented May 10, 2012

Copy link
Copy Markdown

Yet another +1.

@tagawa

tagawa commented May 11, 2012

Copy link
Copy Markdown

Another +1 here.

@andreasbovens

Copy link
Copy Markdown

And another +1 from me.

@freddywang

Copy link
Copy Markdown

for Opera, use

window.addEventListener('message', callback, false)

instead of

window.addEventListener('message', callback, !1)

I checked on opera 12, it doesn't work when we pass !1 as third argument of addEventListener method

@abhishekdev

Copy link
Copy Markdown

If not removed this "sniffing" statement should be modified for compatibility with jQuery 1.9.x+ as $.browser is deprecated now.

@Calvein

Calvein commented Apr 15, 2013

Copy link
Copy Markdown

👍

1 similar comment
@lukeasrodgers

Copy link
Copy Markdown

👍

@damienwhaley

Copy link
Copy Markdown

Further to this I have modified the browser sniff so that it does not fail on jQuery 1.9.x+ and I have added a note to the README to use the jQuery.browser plugin.

ben-duo added a commit to duosecurity/duo_ruby that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_splunk that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_perl that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_confluence that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_wordpress that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_dotnet that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_java that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_coldfusion that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_php that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_nodejs that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_python that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_mediawiki that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_drupal that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_mediawiki that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_classicasp that referenced this pull request Jan 3, 2014
@miketaylr

Copy link
Copy Markdown
Author

hi ben, miss u. ❤️

@vladikoff

Copy link
Copy Markdown

Yesss!

@buritica

Copy link
Copy Markdown

🎂 happy bday PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.