Skip to content

fix/#92 filter existing diagnostics based on severity level when severity level is changed #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidramnero merged 1 commit into from
Jul 27, 2026
Merged

fix/#92 filter existing diagnostics based on severity level when severity level is changed #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,18 @@ function parseMinSeverity(str: string): SeverityNumber {
}
}

function filterOutDiagnosticsBelowSeverityLevel(diagnosticCollection : vscode.DiagnosticCollection, severity : vscode.DiagnosticSeverity) {
diagnosticCollection.forEach((uri : vscode.Uri, diagnostics : readonly vscode.Diagnostic[], collection: vscode.DiagnosticCollection) => {
const filteredDiagnostics = diagnostics?.filter((diagnostic : vscode.Diagnostic) => {
if (severityToNumber(diagnostic.severity) < severityToNumber(severity)) {
return false;
}
return true;
});
collection.set(uri, filteredDiagnostics);
});
}

function updateProgressIndicator(): void {
if (checksRunning) {
cppcheckProgressIndicator.text = `$(loading~spin) Cppcheck Running ..`;
Expand Down Expand Up @@ -243,6 +255,9 @@ export async function activate(context: vscode.ExtensionContext) {
selection.value,
vscode.ConfigurationTarget.Workspace
);

// Clear diagnostics below severity level selected from the problems tab
filterOutDiagnosticsBelowSeverityLevel(diagnosticCollection, parseSeverity(selection.value));

updateMinSeverityOption();
}
Expand Down
Loading