fix(mcp-server): point types metadata to emitted declarations#147
Draft
miguelangaranocurrents wants to merge 3 commits into
Draft
fix(mcp-server): point types metadata to emitted declarations#147miguelangaranocurrents wants to merge 3 commits into
miguelangaranocurrents wants to merge 3 commits into
Conversation
Update package.json types paths to dist/api.d.mts to match tsdown output, add pack/install coverage for declaration files, and use Node-resolved npm/npx in integration tests for Windows compatibility. Excludes unrelated package-lock.json changes from upstream PR #146.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Keep only the package.json types metadata change and declaration-file integration test; revert execNpm/spawnNpx and remove test/npm-exec.ts.
Re-add test/npm-exec.ts and npm/npx wrappers for Windows-compatible integration tests alongside the types metadata fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the substantive changes from #146 without the unrelated
package-lock.jsonchurn.package.jsontypesandexports["."].typesat emitteddist/api.d.mts(tsdown does not emitapi.d.ts)npm/npxvia the current Node runtime in integration tests for Windows compatibilityExcluded from #146
package-lock.jsonhono downgradeValidation
npm run test:run— 12 files / 385 tests passedNotes
Credit: based on contribution from @itosa-kazu in #146