Fix MetronomeMark objects silently dropped from Lilypond output - #1993
Draft
Emerson936 wants to merge 1 commit into
Draft
Fix MetronomeMark objects silently dropped from Lilypond output#1993Emerson936 wants to merge 1 commit into
Emerson936 wants to merge 1 commit into
Conversation
The Lilypond translator's element dispatch never recognized
MetronomeMark, so tempo markings were dropped entirely when writing
to lily. Also fixes LyTempoEvent.stringOutput(), which ignored a
paired stenoDuration when no tempoRange was given, and its docstring,
which showed an invalid steno duration ('quarter' instead of '4').
Fixes cuthbertLab#1852
This PR is AI-assisted (>10 lines).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Emerson936
marked this pull request as draft
August 3, 2026 02:33
Member
|
great PR. fix lint; move the "New in v.11 to the end of the docstring", and I'll be happy to merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MetronomeMark objects being silently dropped from LilyPond output.
Changes:
MetronomeMarkdispatch branch toLilypondConverter.appendM21ObjectToContext(previously it fell through unhandled and was dropped).lyEmbeddedScmFromMetronomeMark(), which converts aMetronomeMark's referent/number into aLyTempoEvent.LyTempoEvent.stringOutput(), which ignored a pairedstenoDurationwhen notempoRangewas given, producing invalid syntax.LyStenoDurationdocstring example, which showed an invalid steno duration ('quarter'instead of'4').Fixes #1852
AI-assisted with Claude (>10 lines).