Make changes to non-paged attention path#3
Open
sudhakarsingh27 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
sudhakarsingh27
commented
Jan 29, 2025
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
sudhakarsingh27
force-pushed
the
pr-1355-updates
branch
from
January 29, 2025 02:31
16db0ce to
57d501e
Compare
cyanguwa
force-pushed
the
paged_attention
branch
from
February 22, 2025 00:02
5b4117b to
7331a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-paged attention path needed to be changed to make the gemma tutorial work