dapr mcpservers: skip cert-expiry check in self-hosted mode, validate --output - #1676
Conversation
…tput dapr mcpservers ran kubernetes.CheckForCertExpiry unconditionally in PostRun, so a purely local resources-directory listing reached for kubeconfig and cluster access; guard it behind kubernetesMode like dapr list does. Also validate --output in PreRun, matching dapr list, instead of silently accepting unknown values. Fixes dapr#1675 Signed-off-by: Mukul <nmukul32@gmail.com>
|
The red check here is |
|
@holopin-bot @Mukuwul cli-badge Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @Mukuwul, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cms2zuh1i0001i604rx9gpf7x This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Two fixes for the new
dapr mcpserverscommand:kubernetes.CheckForCertExpiry()unconditionally, so a purely local resources-directory listing reached for kubeconfig/cluster access. It's now guarded behindkubernetesMode, matching whatdapr listdoes.--outputis validated.dapr mcpservers -o tableused to be silently accepted and behave like the default; it now fails in PreRun with the valid values (json, yaml, list), matchingdapr list's behavior.The
-nshorthand clash described in the issue (name here vs namespace ininit/uninstall/workflow/scheduler) is deliberately not touched - changing a shorthand is breaking, so that part needs a maintainer call first.Issue reference
Fixes #1675
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: