Fix experiment create trace location#5993
Open
radakam wants to merge 2 commits into
Open
Conversation
The fake ExperimentCreate rebuilt the stored experiment field-by-field and never copied TraceLocation from the request. TraceLocation is immutable and the real GetExperiment echoes it back, so the direct-engine diff saw the field as local-present vs remote-absent and spuriously recreated the experiment on every subsequent plan/deploy. Copy TraceLocation through so the fake mirrors backend behaviour.
Collaborator
Integration test reportCommit: 50c0e74
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 2 slowest tests (at least 2 minutes):
|
radakam
marked this pull request as ready for review
July 21, 2026 09:48
pietern
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test server's fake
ExperimentCreaterebuilt the experiment field-by-field and droppedTraceLocation. Since it's immutable and the realGetExperimentechoes it back, the direct-engine diff saw local-present vs remote-absent and spuriously recreated the experiment on every plan/deploy. Fix: passTraceLocationthrough.Found by fuzz testing.