Agent files shared template#6017
Open
lennartkats-db wants to merge 2 commits into
Open
Conversation
The four standalone templates (default, default-scala, default-sql,
dbt-sql) carried byte-identical AGENTS.md/CLAUDE.md files. Move the
content into a single shared library (templates/common/library) that
newRenderer parses into every template's namespace, and reduce each
template's files to one-line {{template}} stubs. Rendered output is
unchanged.
Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
lennartkats-db
requested review from
janniklasrose,
parthban-db and
renaudhartert-db
July 21, 2026 19:54
Collaborator
Integration test reportCommit: bc768fc
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
|
Comment on lines
+78
to
+79
| // Parse the shared library before the template's own, so a same-named | ||
| // definition in the template's library takes precedence. |
Contributor
There was a problem hiding this comment.
Parse the shared library before the template's own, so a same-named definition in the template's library takes precedence.
would be good to assert this via at least a unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #5996. The four standalone templates (
default,default-scala,default-sql,dbt-sql) carried byte-identicalAGENTS.md/CLAUDE.mdfiles.This moves the content into one shared library (
templates/common/library)that
newRendererparses into every template's namespace, and reduces eachtemplate's files to one-line
{{template}}stubs.mainbefore mergingTests
Template and pipelines acceptance goldens are unchanged;
task test-update-templatespasses with no diff.