Skip to content

chore: Remove unused keyring dependency#1588

Merged
sd-db merged 3 commits into
mainfrom
sd-db/codex/remove-keyring-dependency
Jul 21, 2026
Merged

chore: Remove unused keyring dependency#1588
sd-db merged 3 commits into
mainfrom
sd-db/codex/remove-keyring-dependency

Conversation

@sd-db

@sd-db sd-db commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Resolves #

Description

dbt-databricks no longer uses keyring; token caching moved to the Databricks SDK, but the direct dependency and its old lock entries remained. This removes the unused direct dependency, stale transitive packages from both lockfiles, and skipped tests that only exercised the retired keyring-backed implementation. There is no runtime authentication behavior change.

Checklist

  • hatch run pytest tests/unit/test_auth.py -q -n 0 --profile databricks_cluster — 19 passed, 2 skipped
  • hatch run code-quality — passed, including uv-lock and the public-PyPI URL check
  • Validated the edited uv.lock graph — 103 packages with no missing dependency references
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

Remove obsolete lockfile entries and skipped legacy keyring tests.
@sd-db
sd-db requested a review from jprakash-db as a code owner July 14, 2026 06:02
@sd-db sd-db changed the title [deps] Remove unused keyring dependency chore[deps]: Remove unused keyring dependency Jul 14, 2026
@github-actions

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@sd-db sd-db changed the title chore[deps]: Remove unused keyring dependency chore: Remove unused keyring dependency Jul 14, 2026
@sd-db
sd-db merged commit 9580603 into main Jul 21, 2026
10 checks passed
@sd-db
sd-db deleted the sd-db/codex/remove-keyring-dependency branch July 21, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants