Skip to content

Added pre-upgrade check for defect CSCwt69100#385

Open
Priyanka-Patil14 wants to merge 5 commits into
datacenter:v4.2.0-devfrom
Priyanka-Patil14:CSCwt69100-fix-clean
Open

Added pre-upgrade check for defect CSCwt69100#385
Priyanka-Patil14 wants to merge 5 commits into
datacenter:v4.2.0-devfrom
Priyanka-Patil14:CSCwt69100-fix-clean

Conversation

@Priyanka-Patil14
Copy link
Copy Markdown

@Priyanka-Patil14 Priyanka-Patil14 commented May 15, 2026

Summary:
-This PR adds a new validation check: Stale dbgacEpgSummaryTask Objects.

-The check detects stale dbgacEpgSummaryTask objects stuck in processing state that can cause policymgr to crash on all APICs during upgrade (CSCwt69100).

What Changed:

  • Added stale_epg_summary_task_check in aci-preupgrade-validation-script.py
  • Added validation documentation in docs/docs/validations.md
  • Added dedicated unit tests and test data under:
    tests/checks/stale_epg_summary_task_check/

Check Behavior:

  • Returns `MANUAL' if target version is missing
  • Returns N/A if target version is not in affected range (<= 6.1(5e) or <= 6.2(1g))
  • Returns PASS if no dbgacEpgSummaryTask objects found in processing state
  • Returns PASS if objects found but startTs is within 24 hours
  • Returns FAIL_O if any dbgacEpgSummaryTask object has startTs older than 24 hours

Test Results:

Note: Added FAIL log from CU as lab repro is not feasible.

@Priyanka-Patil14 Priyanka-Patil14 changed the base branch from v4.1.0-dev to v4.2.0-dev May 25, 2026 04:53
Copy link
Copy Markdown
Contributor

@Harinadh-Saladi Harinadh-Saladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see you have added only full script run logs. Can you attach your function alone logs. Please add the logs for PASS,FAIL and NA scenarios.

As Lovkesh has confirmed that attaching FAIL logs is not required (Issue is not recreatable, since repro factor is very less), pls attach cu log as a fail evidence.

Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py Outdated
Comment thread aci-preupgrade-validation-script.py
Copy link
Copy Markdown
Contributor

@Harinadh-Saladi Harinadh-Saladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comments

Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread docs/docs/validations.md Outdated
@Harinadh-Saladi
Copy link
Copy Markdown
Contributor

Pls add pytest logs for your check as you added additional test cases.

@Priyanka-Patil14
Copy link
Copy Markdown
Author

Pls add pytest logs for your check as you added additional test cases.

Attached the pytest logs for the check.
CSCwt69100_pytest.txt

Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Copy link
Copy Markdown

@lovkeshsharma702 lovkeshsharma702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirement already satisfied: MarkupSafe>=0.23 in ./venv27/lib/python2.7/site-packages (from jinja2==2.11.3->-r tests/requirements-py27.txt (line 7)) (1.1.1)
$ pytest --junitxml=report.xml
============================= test session starts ==============================
platform linux2 -- Python 2.7.11, pytest-4.6.11, py-1.11.0, pluggy-0.13.1
rootdir: /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script, inifile: pytest.ini
collected 875 items / 1 errors / 874 selected
==================================== ERRORS ====================================
_ ERROR collecting tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py _
venv27/lib/python2.7/site-packages/_pytest/python.py:507: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
venv27/lib/python2.7/site-packages/py/_path/local.py:704: in pyimport
import(modname)
E File "/builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py", line 62
E SyntaxError: Non-ASCII character '\xe2' in file /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/tests/checks/stale_epg_summary_task_check/test_stale_epg_summary_task_check.py on line 62, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

  • generated xml file: /builds/aci-pre-upgrade-validation/aci-pre-upgrade-validation-script/report.xml -
    !!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
    =========================== 1 error in 10.94 seconds ===========================
    Uploading artifacts for failed job
    00:03
    Uploading artifacts...
    report.xml: found 1 matching artifact files and directories
    Uploading artifacts as "junit" to coordinator... 201 Created id=440 responseStatus=201 Created token=glcbt-64
    ERROR: Job failed: exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants