Add validation config, goldens, counters, and existing statvar mcf for statistics_poland - #2129
Open
abhishekjaisw wants to merge 5 commits into
Open
Conversation
…r statistics_poland
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Poland Census import configuration, adds validation configurations with golden data, and introduces a recon_lookup_api flag in the schema reconciler. The review feedback highlights that changing the default value of recon_lookup_api to False globally will break other imports, so it should remain True by default. Additionally, the reviewer advises against silently falling back to /tmp/source_files on permission errors in the download script, and notes that counters/.csv and golden_data/.csv should not be included in the source_files list in manifest.json.
…s, and error handling
…alse for statistics_poland
abhishekjaisw
requested review from
SandeepTuniki,
ajaits,
balit-raibot and
saanikaaa
August 4, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR configures validation, golden verification sets, and output counters for the
statistics_polandstatvar import.Changes Included:
Manifest Configuration (
statvar_imports/statistics_poland/manifest.json):--output_counters=counters/StatisticsPoland_output_counters.csvto the processor script invocation.--existing_statvar_mcf=gs://unresolved_mcf/scripts/statvar/stat_vars.mcfto reuse existing resolved StatVars."counters/*.csv"and"golden_data/*.csv"tosource_filesso outputs and goldens are preserved and uploaded to GCS."validation_config_file": "validation_config.json".invoke_import_validation,invoke_import_tool,invoke_differ_tool, and set"use_autopush_dc_api": falseinconfig_override.Golden Files & Validation Config:
statvar_imports/statistics_poland/validation_config.jsonwithGOLDENS_CHECKandDELETED_RECORDS_PERCENTrules.golden_data/golden_summary_report.csvandgolden_data/golden_observations.csvfrom verified prod runs.Metadata & Script Updates:
recon_property,"variableMeasured,measurementMethod"inStatisticsPoland_metadata.csvto filter reconciliation to relevant variables and avoid excessive DC API queries on numeric observations.download_input_data.pyto address pandas groupby transpose compatibility and removed/tmpfallback on PermissionError.README.mddocumentation with new CLI flags.Testing:
datcom-infosys-dev)../run_tests.sh -l.