Mapping UN GEOGRAPHY to DCIDs - #2132
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the autopush DC API in the executor configuration and introduces a new mapping directory for UN Geography to Data Commons Places, including a README and a Template MCF (un_places.tmcf). The reviewer suggested correcting the directory path prefix in the README to avoid confusion, as 'data' is the repository name rather than a subdirectory.
| @@ -0,0 +1,99 @@ | |||
| # UN Geography to Data Commons Places Mapping | |||
|
|
|||
| This directory (`data/scripts/un/places`) contains the definitions and mappings from United Nations (UN) geography codes to **Data Commons (DC) Places**. | |||
There was a problem hiding this comment.
The directory path is referenced as data/scripts/un/places, but the repository root is actually scripts/un/places (since data is the name of the repository itself, not a subdirectory). To avoid confusion and maintain consistency with other path references in the codebase, please remove the data/ prefix.
| This directory (`data/scripts/un/places`) contains the definitions and mappings from United Nations (UN) geography codes to **Data Commons (DC) Places**. | |
| This directory (scripts/un/places) contains the definitions and mappings from United Nations (UN) geography codes to **Data Commons (DC) Places**. |
1 participant
The PR includes the mapping for UN GEOGRAPHY codes for type Country and City to DCIDs.
This also includes steps to propose new place mappings.
The updates to CSV will be imported into Data Commons.