Differ updates and fixes - #2135
Open
vish-cs wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new output file, nodes-original.mcf, to the import differ tool to capture the original values of modified MCF nodes before modification. It also updates the list parsing and string representation logic in differ_utils.py and import_differ.py. The review feedback highlights that the new logic for parsing comma-separated lists is fragile and fails to handle lists of quoted strings correctly, suggesting a more robust regex-based approach.
ajaits
reviewed
Aug 5, 2026
ajaits
reviewed
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the differ:
a) Added a new output file containing the original values of modified nodes (for debugging)
b) Updated MCF parsing logic to handle quoted strings cleanly
c) Fixes the differ counter names to check for SKIP state in the executor