Allow parallel execution of BQ federation jobs - #710
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 9 complexity
Metric Results Complexity 9
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request introduces parallel execution of aggregation pipelines for multiple imports using a ThreadPoolExecutor, along with a new --max_parallel_imports configuration option. It also updates the import list parser to handle dictionary items containing an importName key. Key feedback includes addressing a potential race condition during the lazy initialization of the bigquery.Client by warming it up on the main thread before starting the thread pool, and raising explicit errors instead of silently casting unexpected types or missing keys to strings in parse_import_list to maintain data quality and prevent downstream failures.
SandeepTuniki
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this, Vishal. Left one comment, but its not a blocker.
Uh oh!
There was an error while loading. Please reload this page.