Skip to content

Allow parallel execution of BQ federation jobs - #710

Merged
vish-cs merged 2 commits into
datacommonsorg:masterfrom
vish-cs:federation
Aug 5, 2026
Merged

Allow parallel execution of BQ federation jobs#710
vish-cs merged 2 commits into
datacommonsorg:masterfrom
vish-cs:federation

Conversation

@vish-cs

@vish-cs vish-cs commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
  • Since we run aggregation for multiple imports, allowing parallel execution of BQ federation jobs.
  • Added a fix to check for BQ string limit in provenance summary generation
  • Allow import list to be a JSON type in addition to a CSV
  • Disabled several failing unit test failures (temporarily) to unblock merge

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

🟢 Metrics 9 complexity

Metric Results
Complexity 9

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces parallel execution of aggregation pipelines for multiple imports using a ThreadPoolExecutor, along with a new --max_parallel_imports configuration option. It also updates the import list parser to handle dictionary items containing an importName key. Key feedback includes addressing a potential race condition during the lazy initialization of the bigquery.Client by warming it up on the main thread before starting the thread pool, and raising explicit errors instead of silently casting unexpected types or missing keys to strings in parse_import_list to maintain data quality and prevent downstream failures.

Comment thread pipeline/workflow/aggregation-helper/aggregation/orchestrator.py
Comment thread pipeline/workflow/aggregation-helper/main.py Outdated

@SandeepTuniki SandeepTuniki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this, Vishal. Left one comment, but its not a blocker.

Comment thread pipeline/workflow/aggregation-helper/main.py
@vish-cs
vish-cs merged commit f9da5a4 into datacommonsorg:master Aug 5, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants