Skip to content

fix(chat): page agent history by compound cursor, not bare timestamp #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 24, 2026
Merged

fix(chat): page agent history by compound cursor, not bare timestamp #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions frontend/src/pages/agent-detail/AgentDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,8 +2428,11 @@ export default function AgentDetailPage() {
}),
}));
setChatMessages(parsed);
// Round-trip the backend's compound `<created_at>|<id>` cursor. A bare
// created_at cannot page past a batch of messages that share one timestamp
// (e.g. a burst of tool_call rows), so older messages would never load.
setChatOldestTimestamp(
messages.length > 0 ? messages[0].created_at : null,
messages.length > 0 ? (messages[0].cursor ?? messages[0].created_at) : null,
);
setChatHistoryHasMore(messages.length >= HISTORY_PAGE_SIZE);
setMessagesLoadedRuntimeKey(buildSessionRuntimeKey(agentId, sessionId));
Expand Down Expand Up @@ -2753,8 +2756,9 @@ export default function AgentDetailPage() {
}),
}));

// Set the oldest message timestamp for cursor-based pagination
const oldestTimestamp = msgs.length > 0 ? msgs[0].created_at : null;
// Set the oldest message cursor for pagination. Use the backend's compound
// `<created_at>|<id>` cursor so a batch of equal-timestamp messages can be paged past.
const oldestTimestamp = msgs.length > 0 ? (msgs[0].cursor ?? msgs[0].created_at) : null;

if (writable) {
setChatMessages(preParsed);
Expand Down Expand Up @@ -3991,8 +3995,9 @@ export default function AgentDetailPage() {
const el = historyContainerRef.current;
const oldScrollHeight = el?.scrollHeight ?? 0;
setHistoryMsgs(prev => [...preParsed, ...prev]);
// Update the oldest timestamp (first message in the new batch, since messages are in chronological order)
setHistoryOldestTimestamp(msgs[0].created_at);
// Update the oldest cursor (first message in the new batch, since messages are in chronological order).
// Round-trip the compound `<created_at>|<id>` cursor so equal-timestamp batches don't stall pagination.
setHistoryOldestTimestamp(msgs[0].cursor ?? msgs[0].created_at);
setHistoryHasMore(msgs.length >= HISTORY_PAGE_SIZE);
// Restore scroll position after new messages are prepended
requestAnimationFrame(() => {
Expand Down Expand Up @@ -4040,8 +4045,9 @@ export default function AgentDetailPage() {
const el = chatContainerRef.current;
const oldScrollHeight = el?.scrollHeight ?? 0;
setChatMessages(prev => [...preParsed, ...prev]);
// Update the oldest timestamp (first message in the new batch, since messages are in chronological order)
setChatOldestTimestamp(msgs[0].created_at);
// Update the oldest cursor (first message in the new batch, since messages are in chronological order).
// Round-trip the compound `<created_at>|<id>` cursor so equal-timestamp batches don't stall pagination.
setChatOldestTimestamp(msgs[0].cursor ?? msgs[0].created_at);
setChatHistoryHasMore(msgs.length >= HISTORY_PAGE_SIZE);
// Restore scroll position after new messages are prepended
requestAnimationFrame(() => {
Expand Down