Clarify model step limit copy in agent settings - #788
Merged
1 commit merged intoJul 24, 2026
Merged
Conversation
The max_tool_rounds control limits model-result steps rather than tool calls, so its previous wording caused operators to compare an unrelated tool count with the Runtime ceiling. Align the Chinese, English, and fallback copy with the enforced semantics, including wait and error results. Constraint: Preserve the existing setting key, numeric range, default, and Runtime behavior Confidence: high Scope-risk: narrow Directive: Keep this copy aligned with node_executor model_step_count semantics Tested: Frontend node tests (85 passed); npm production build; i18n JSON parsing; git diff check Not-tested: Browser screenshot on a deployed server
Y1fe1Zh0u
closed this pull request by merging all changes
into
dataelement:main
in
5564700
Y1fe1Zh0u
added a commit
that referenced
this pull request
Jul 24, 2026
Integrate PR #788 so testers evaluate the Runtime model-step ceiling with accurate Chinese and English copy. Constraint: Keep this integration copy-only Confidence: high Scope-risk: narrow Tested: Merge completed without conflicts Not-tested: Combined frontend suite and visual confirmation pending
Y1fe1Zh0u
added a commit
that referenced
this pull request
Jul 24, 2026
Waiting-to-cancel transitions can emit distinct delivery receipts from one preserved checkpoint, while legacy group members may no longer resolve an Agent model. Narrow checkpoint uniqueness only for delivery receipts and let shared compaction fall back to the configured Group Compact model when no active Agent model remains. Constraint: Control-plane cancel must preserve the last authoritative Graph checkpoint Rejected: Fabricate a cancel checkpoint | violates the existing Runtime checkpoint contract Confidence: high Scope-risk: narrow Reversibility: clean before distinct same-checkpoint delivery rows are written Directive: Keep delivery idempotency keyed by run_id and idempotency_key Tested: 110 targeted backend tests, Alembic head validation, Python compileall, scoped Ruff Not-tested: Live 3010 migration and reconciliation before commit Related: #785 #786 #787 #788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The setting is stored as
max_tool_rounds, but Runtime enforces it asmodel_turn_limitagainstmodel_step_count. The previous copy encouraged users to compare the visible number of tool calls with the Runtime model-step ceiling, even though those are different counters.This PR changes copy only. It does not change the setting key, numeric range, default value, persistence, or Runtime behavior.
Validation
npm test— 85 tests passednpm run build— passedgit diff --check— passedNot tested: visual confirmation on a deployed server.