Fix/v1.11.3 upgrade ci compat - #794
Open
Y1fe1Zh0u wants to merge 2 commits into
Open
Conversation
The upgrade test previously special-cased v1.11.2 and let the target image migrate beyond the source image's known Alembic graph. Discover the source image heads and only use target migration code to repair to that boundary when source bootstrap fails. Constraint: The upgrade source is selected dynamically from the previous release tag Rejected: Pin a known revision | breaks when the previous release changes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Never expose target-only revisions to the source image before source assertions complete Tested: sh -n; bash -n; Alembic head and history resolution; git diff --check Not-tested: Full Docker upgrade workflow because the local Docker daemon is unavailable
Derive source heads and their direct parents from the source image, commit the historical parent schema with source migrations, and permit target code to replace only a changed source-head migration. Verify the stored Alembic heads before starting the source app without bootstrap. Constraint: Target Base.metadata must never bootstrap the source-version database Rejected: Retry the target image from an empty database | fabricates target schema at a source revision Rejected: Run every revision in a separate container | preserves boundaries but adds unnecessary CI startup overhead Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep target migrations behind a committed source-schema boundary Tested: sh, bash, and dash syntax; 17 scoped pytest tests; v1.11.2 graph and digest resolution; git diff check Not-tested: Full Docker upgrade workflow because the local Docker daemon is unavailable
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist