Skip to content

Add more test for custom fakers#1859

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:custom
Jun 27, 2026
Merged

Add more test for custom fakers#1859
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:custom

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Currently pass however it might be a guard before PR like #1819
is ready to be merged

}

@Deterministic
public String value() {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge case for different fakers with same methods

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (a179fdd) to head (2306483).
⚠️ Report is 8 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1859      +/-   ##
============================================
+ Coverage     92.37%   92.48%   +0.10%     
- Complexity     3515     3560      +45     
============================================
  Files           344      345       +1     
  Lines          6968     7037      +69     
  Branches        684      686       +2     
============================================
+ Hits           6437     6508      +71     
  Misses          366      366              
+ Partials        165      163       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 3.0.0 milestone Jun 27, 2026
@asolntsev asolntsev added the enhancement New feature or request label Jun 27, 2026
@snuyanzin snuyanzin merged commit 488a72e into datafaker-net:main Jun 27, 2026
17 checks passed
@kingthorin

Copy link
Copy Markdown
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants