Enable spotless index#1860
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
============================================
- Coverage 92.58% 92.51% -0.08%
+ Complexity 3565 3562 -3
============================================
Files 346 346
Lines 7050 7050
Branches 684 684
============================================
- Hits 6527 6522 -5
- Misses 363 365 +2
- Partials 160 163 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@snuyanzin Do understand correctly that it will help during local development, but would not be used in GitHub Actions? |
|
yes, it is for local only my current fear about ci: I don't know how to review it since it will appear in every PR after that |
|
We can create a separate branch like "main2" with the shared index, and create few PRs to "main2". But this is optional, of course. |
|
looks like https://github.com/diffplug/spotless/tree/main/plugin-maven#ratchet |
| - name: Determine Spotless ratchet ref | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ github.event_name }}" = "pull_request" ]; then | ||
| ref="${{ github.event.pull_request.base.sha }}" | ||
| else | ||
| ref="${{ github.event.before }}" | ||
| [ "$ref" = "0000000000000000000000000000000000000000" ] && ref="" | ||
| fi | ||
| [ -n "$ref" ] && echo "RATCHET=-DratchetFrom=$ref" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
to make generic in case of multiple branches
|
test commit shows spotless keeps working https://github.com/datafaker-net/datafaker/actions/runs/28367702772/job/84037564425?pr=1860 |
Also more info about it
https://github.com/diffplug/spotless/tree/main/plugin-maven#incremental-up-to-date-checking-and-formatting