Add optional original_file_path to Assertion protos#2200
Closed
rafal-hawrylak wants to merge 1 commit into
Closed
Conversation
Lets callers record a source declaration path distinct from the existing `file_name`/`filename`. When the new field is unset, consumers continue to use `file_name` as today. Backwards-compatible: additive, optional.
ikholopov-omni
requested changes
Jun 9, 2026
ikholopov-omni
left a comment
ikholopov-omni
left a comment
Collaborator
There was a problem hiding this comment.
I don't think we have a good enough justification for adding such a thing. The semantics here are too murky and require a broader discussion.
Collaborator
Author
|
Confirmed, no need for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets callers record a source declaration path distinct from the existing
file_name/filename. When the new field is unset, consumers continue to usefile_nameas today.Backwards-compatible: additive, optional.