Don't retry all 401's and add a session handler#11
Merged
Conversation
beneboy
approved these changes
Jun 9, 2026
added 2 commits
June 9, 2026 16:40
- BaseClient and IfmClient each build one requests.Session at construction and route every send through it - Session-wide verify default set once; per-call Authorization headers still merged at request time - _build_session helper centralises the verify default so new endpoints can't forget the flag - verify_ssl tests repointed at client._session.request to reflect the new dispatch site
- A 401 on a requires_authorization=False call now surfaces as-is instead of triggering a re-auth and replay - Anonymous 401s (e.g. admin-install on an already-configured instance) no longer misreport as bad credentials - Avoids a wasted login round-trip on calls the caller explicitly marked as not needing auth - Test asserts a single request and no /api/auth/token/login/ replay on an anonymous 401 Closes #9
carlosfunk
force-pushed
the
feat/session-pooling
branch
from
79f462f to
c7b35ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9