feat: Add informix to DatabaseType enum#13
Merged
Merged
Conversation
Informix is a standard relational SQL database (host/port/database/ user/password/schema), so it routes through the default DatabaseConnectionConfig like postgres, oracle, db2_luw and db2i — no dedicated connection config class or DB_TYPE_MAP entry needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
carlosfunk
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
informixas a supported database type.Informix is a standard relational SQL database (host/port/database/user/password/schema), so it routes through the default
DatabaseConnectionConfig— exactly likepostgres,oracle,db2_luwanddb2i. Those types deliberately aren't inDB_TYPE_MAPand don't need a dedicated connection config class, so this is a single-line enum addition. (Contrast withdatabricks, which needed a bespoke config class for its non-standard connection params.)Change
datamasque/client/models/connection.py: addinformix = "informix"to theDatabaseTypeenum.Verification
DatabaseType, so there are no parallel spots to update.tests/test_connections.py— 49 passed.informixpayload dispatches toDatabaseConnectionConfig, resolves toDatabaseType.informix, and serializes back todb_type: "informix".Note
This assumes the DataMasque server accepts
"informix"as itsdb_typevalue — the client passes the string through unchanged.🤖 Generated with Claude Code