Allow bench workflow to run on PRs from forks#656
Closed
ashkrisk wants to merge 2 commits into
Closed
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
jshook
reviewed
Apr 14, 2026
| # Default branches based on event type | ||
| if [[ "${{ github.event_name }}" == "pull_request" ]]; then | ||
| echo "Pull request detected. Using main and PR branch: ${{ github.head_ref }}" | ||
| BRANCHES='["main", "${{ github.head_ref }}"]' |
Contributor
There was a problem hiding this comment.
This seems to be a change from "branch" to "sha", rather than also adding support for the sha. Don't we need it to work for both?
Contributor
Author
There was a problem hiding this comment.
Yes; but this works for two reasons:
- Git refs can be either branch names or SHAs.
- The
elifcondition just after this handles cases where the workflow is manually dispatched by providing a branch name (or SHA). This conditional branch only deals with PRs, and that gives us the freedom to pick how we want to refer to the head commit, either by branch or SHA
Contributor
Author
There was a problem hiding this comment.
In the latest PR (#688) I've changed this to use the Github ref instead of the SHA
Contributor
Author
|
Closing in favour of #688 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.