Add \ne to edit a named query in the external editor - #1609
Merged
Conversation
\ne <name> loads a named query's SQL into $EDITOR and writes the edited result back to the [named queries] section on save, creating it if it does not exist. Complements \ns for editing longer queries. Addresses the editor part of issue dbcli#1430.
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ed-query # Conflicts: # AUTHORS # changelog.rst
Contributor
|
Thank you @DiegoDAF . |
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Aug 3, 2026
…cherry-pick candidates
diego-feito-stori
pushed a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Aug 11, 2026
The "edit sql in file with external editor" scenario errors intermittently on slow CI runners: pexpect's expect_exact waited only 2 seconds for the ex-mode banner. It has bitten upstream's CI repeatedly (PRs dbcli#1543/dbcli#1544/dbcli#1609) and now our fork's CI on main (cee716d run: unit 3139 passed, 61 scenarios passed, the only error was this scenario on 3.10 while 3.11 was fully green). All expect timeouts in iocommands.py bumped to 10s. Passing runs are not slowed: pexpect returns as soon as the expected text appears; the timeout only bounds how long a FAILING wait lasts. Verified locally: behave features/iocommands.feature green against a throwaway PG (2 scenarios, 12 steps). Same patch offered to upstream in the dbcli#1543 review thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
\ne <name>, a special command to edit a named query in the external editor ($EDITOR).It loads the named query's SQL into the editor and, on save, writes the edited result back to the
[named queries]section of the config (creating the entry if it does not exist). This complements\ns(save) by making it practical to edit longer named queries without retyping them, mirroring how\e/\ev/\efalready open the editor.Addresses the editor part of #1430.
Behavior
\ne fooon an existing query: opens it in$EDITOR; saving updates it.\ne fooon a new name: opens an empty editor; saving creates it.Tests
tests/test_main.py::test_edit_named_querycovers create / update / no-change / empty / editor-error / usage (editor mocked, no DB needed).Changelog
Upcomingsection.