Applied Cursor's suggestions to address straightforward TODOs.#183
Open
tameware wants to merge 1 commit into
Open
Applied Cursor's suggestions to address straightforward TODOs.#183tameware wants to merge 1 commit into
tameware wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a few straightforward TODOs by switching core-count detection to standard C++ (std::thread::hardware_concurrency()), simplifying a redundant constructor initializer in SolverContext, and cleaning up an obsolete comment in quick-tricks logic.
Changes:
- Use
std::thread::hardware_concurrency()inSystem::get_cores()with a platform-specific fallback when it returns 0. - Remove redundant
thr_(nullptr)fromSolverContextconstructor initializer list (the member is set immediately in the constructor body). - Remove stale TODO commentary in
QuickTricksPartnerHandNTnow that the logic is settled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| library/src/system/system.cpp | Adds <thread> and prefers std::thread::hardware_concurrency() for core detection, falling back to OS APIs. |
| library/src/solver_context/solver_context.cpp | Cleans up redundant constructor initialization and clarifies ThreadMemoryUsed() accounting comment. |
| library/src/quick_tricks.cpp | Removes obsolete TODO comments next to existing quick-trick adjustment logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.