Skip to content

Applied Cursor's suggestions to address straightforward TODOs.#183

Open
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:cpp-todos
Open

Applied Cursor's suggestions to address straightforward TODOs.#183
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:cpp-todos

Conversation

@tameware

Copy link
Copy Markdown
Contributor

No description provided.

@tameware tameware marked this pull request as ready for review June 12, 2026 04:26
@zzcgumn zzcgumn requested a review from Copilot June 12, 2026 16:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a few straightforward TODOs by switching core-count detection to standard C++ (std::thread::hardware_concurrency()), simplifying a redundant constructor initializer in SolverContext, and cleaning up an obsolete comment in quick-tricks logic.

Changes:

  • Use std::thread::hardware_concurrency() in System::get_cores() with a platform-specific fallback when it returns 0.
  • Remove redundant thr_(nullptr) from SolverContext constructor initializer list (the member is set immediately in the constructor body).
  • Remove stale TODO commentary in QuickTricksPartnerHandNT now that the logic is settled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
library/src/system/system.cpp Adds <thread> and prefers std::thread::hardware_concurrency() for core detection, falling back to OS APIs.
library/src/solver_context/solver_context.cpp Cleans up redundant constructor initialization and clarifies ThreadMemoryUsed() accounting comment.
library/src/quick_tricks.cpp Removes obsolete TODO comments next to existing quick-trick adjustment logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants