add gateway api certificate issuer linter#431
Open
miklezzzz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a certificate linter that checks whether a certificate manifest refers to some specific cluster issuer instead of using templating with global values.
The reason why this linter is required is a templating mistake done in the beginning of introducing Gateway API in DKP. Presumably, some modules have already adopted incorrect templating and are locked in terms of supporting wider range of cluster issuers, provided by DKP.