Skip to content

resolve vsphere-syncer image from module config instead of 000-common#202

Draft
xhable137 wants to merge 3 commits into
mainfrom
remove-csi-vsphere-syncer
Draft

resolve vsphere-syncer image from module config instead of 000-common#202
xhable137 wants to merge 3 commits into
mainfrom
remove-csi-vsphere-syncer

Conversation

@xhable137

@xhable137 xhable137 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Change how the vsphere-syncer sidecar image is resolved in helm_lib_csi_controller_manifests.
Previously the template resolved the image itself via helm_lib_module_common_image_no_fail
(pulling csiVsphereSyncer<Major><Minor> from 000-common digests).
Now the caller module passes the image explicitly via syncerImage in the config dict:

{{- $_ := set $csiControllerConfig "syncerImage" $syncerImage }}
The syncer container (and its VPA policy) only renders when both syncerEnabled: true
and syncerImage is non-empty. This decouples lib-helm from the image location
and allows vSphere modules to move the image out of 000-common.

@xhable137
xhable137 requested review from aleksey-su and pabateman July 6, 2026 10:05
Artem Darmanyan added 2 commits July 20, 2026 13:40
Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
… digests

Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
@xhable137
xhable137 force-pushed the remove-csi-vsphere-syncer branch from bf22e0d to 836e35b Compare July 20, 2026 10:40
Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
@xhable137 xhable137 changed the title remove vsphere syncer container and related logic from csi controller resolve vsphere-syncer image from module config instead of 000-common Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant