resolve vsphere-syncer image from module config instead of 000-common#202
Draft
xhable137 wants to merge 3 commits into
Draft
resolve vsphere-syncer image from module config instead of 000-common#202xhable137 wants to merge 3 commits into
xhable137 wants to merge 3 commits into
Conversation
added 2 commits
July 20, 2026 13:40
Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
… digests Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
xhable137
force-pushed
the
remove-csi-vsphere-syncer
branch
from
July 20, 2026 10:40
bf22e0d to
836e35b
Compare
Signed-off-by: Artem Darmanyan <artem.darmanyan@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how the vsphere-syncer sidecar image is resolved in
helm_lib_csi_controller_manifests.Previously the template resolved the image itself via
helm_lib_module_common_image_no_fail(pulling
csiVsphereSyncer<Major><Minor>from000-commondigests).Now the caller module passes the image explicitly via
syncerImagein the config dict: