Refactor mulliken charge analysis code.#7430
Open
mohanchen wants to merge 1 commit into
Open
Conversation
…depth from 25 to 4 - Move cal_mag() template function to new cal_mag.h header - Remove heavy includes (elecstate_lcao.h, dspin_lcao.h, density_matrix.h) from output_mulliken.h that were only needed by cal_mag() - Replace output_dmk.h and output_sk.h includes with forward declarations in output_mulliken.h (class only holds pointers) - Add output_dmk.h and output_sk.h includes to output_mulliken.cpp (implementation needs complete types) - Update ctrl_scf_lcao.cpp to include cal_mag.h instead of output_mulliken.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…depth from 25 to 4
Reminder
Linked Issue
Fix #...
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)